Add some of the unimplemented specs #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LlemonDuck
approved these changes
Feb 19, 2025
|
Making note here of the fact that the saradomin sword magic hit should be reduced my magic damage reductions e.g. tekton, but merging as is anyway since that will require some specific extra thought |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added all of the unimplemented specs that were simple to implement. In the process, I found a bug with the magic longbow and (newly implemented) seercull specs that transformed all hits to 1s even when using invalid ammo, which I fixed. I also added an
isAmmoInvalid()method toBaseCalc.tsto remove some duplicated code related to that.